Skip to content

Commit

Permalink
Merge pull request #207 Get values before validating
Browse files Browse the repository at this point in the history
Get values before validating
  • Loading branch information
mymarche authored Nov 19, 2024
2 parents ecc2fa0 + 5274571 commit 4091b93
Showing 1 changed file with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,6 @@ public ParameterDefinition copyWithDefaultValue(final ParameterValue defaultValu
public ParameterValue createValue(final String value) {
RestListParameterValue parameterValue = new RestListParameterValue(getName(), value, getDescription());

getValues();
checkValue(parameterValue);
return parameterValue;
}
Expand All @@ -242,7 +241,6 @@ public ParameterValue createValue(final StaplerRequest req,
{
RestListParameterValue value = req.bindJSON(RestListParameterValue.class, jo);

getValues();
checkValue(value);
return value;
}
Expand All @@ -258,7 +256,7 @@ public boolean isValid(ParameterValue value) {
if(value == null || value.getValue() == null) {
return false;
}

getValues();

Check warning on line 259 in src/main/java/io/jenkins/plugins/restlistparam/RestListParameterDefinition.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered line

Line 259 is not covered by tests
return values.stream()
.map(ValueItem::getValue)
.filter(Objects::nonNull)
Expand Down

0 comments on commit 4091b93

Please sign in to comment.