Prevent null pointer exceptions in NextLabelCause #372
Conversation
The equals method and the hashCode method both would throw a null pointer exception if the label in the constructor was null. I doubt that the label in the constructor has ever been null, but it is easy to safeguard those two methods so that they are null-safe.
The code incorrectly tested the equals contract of the wrong class due to my copy and paste error. Test the correct class. Uses the simple() verifier because the UpstreamCause class seems to have complications related to its superclass and I'd rather not spend the time to investigate further. The simple() verifier detected the null pointer exceptions, so it is still better than not testing. Removes temporary check for null pointers, since equalsverifier performs the same checks.
MarkEWaite
force-pushed
the
fix-NPE-in-NextLabelCause-equals-and-hashCode
branch
from
8f91695 to
936cc16
Compare
Thank You and Great work @MarkEWaite |
Prevent null pointer exceptions in NextLabelCause
The equals method and the hashCode method both would throw a null pointer exception if the label in the constructor was null. I doubt that the label in the constructor has ever been null, but it is easy to safeguard those two methods so that they are null-safe.
The test code incorrectly tested the equals contract of the wrong class due to my copy and paste error. Test the correct class.
Uses the simple() verifier because the UpstreamCause class seems to have complications related to its superclass and I'd rather not spend the time to investigate further. The simple() verifier detected the null pointer exceptions, so it is still better than not testing.
Special thanks to @code-arnab for detecting and reporting the mistake in #371 (comment)
Testing done
Automated tests pass locally on Linux. Rely on ci.jenkins.io to test Windows.
Submitter checklist