Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NodeParameterValue and LabelParameterValue test coverage #352

Merged
merged 8 commits into from
Oct 23, 2024

Conversation

pardoner
Copy link
Contributor

@pardoner pardoner commented Oct 22, 2024

Testing done

Tested the label parameters within the node label builder. The Assert method was used to evaluate tests. The automated tests within the console were successful.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@github-actions github-actions bot added the tests Automated test addition or improvement label Oct 22, 2024
@pardoner pardoner marked this pull request as ready for review October 22, 2024 22:11
@pardoner pardoner requested a review from a team as a code owner October 22, 2024 22:11
@MarkEWaite MarkEWaite changed the title Features/testcoverage Improve NodeParameterValue and LabelParameterValue test coverage Oct 23, 2024
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @pardoner .

Several of the statements that you added did not assert their results. I've added assertions for the results.

Several of the additions were further from their assertions than I usually prefer, so I moved the initialization and the assertion nearer each other.

I used hamcrest assertions for the assertions that I added because I find their failure messages easier to understand.

@MarkEWaite MarkEWaite enabled auto-merge (squash) October 23, 2024 00:50
@MarkEWaite MarkEWaite merged commit de19930 into jenkinsci:master Oct 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants