[Jenkins-69756] Improve test coverage

src/test/java/org/jvnet/jenkins/plugins/nodelabelparameter/NodeParameterValueTest.java

@@ -0,0 +1,40 @@
+package org.jvnet.jenkins.plugins.nodelabelparameter;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotEquals;
+import static org.junit.Assert.assertTrue;
+
+import org.junit.Test;
+
+public class NodeParameterValueTest {
+    @Test
+    public void testToString() {
+        NodeParameterValue nvp = new NodeParameterValue("node", "description", "label");
+        assertEquals("[NodeParameterValue: node=label]", nvp.toString());
+    }
+
+    @Test
+    public void testHashCode() {
+        NodeParameterValue nvp = new NodeParameterValue("node", "description", "label");
+        NodeParameterValue nvp2 = new NodeParameterValue("node", "description", "label");
+        assertEquals(nvp.hashCode(), nvp2.hashCode());
+
+        NodeParameterValue nvp3 = new NodeParameterValue("node", "description", "label2");
+        assertNotEquals(nvp, nvp3);
+    }
+
+    @Test
+    public void testEquals() {
+        NodeParameterValue nvp = new NodeParameterValue("node", "description", "label");
+        NodeParameterValue nvp2 = new NodeParameterValue("node", "description", "label");
+        assertTrue(nvp.equals(nvp2));
+
+        NodeParameterValue nvp3 = new NodeParameterValue("node", "description", "label2");
+        assertFalse(nvp.equals(nvp3));
+
+        assertFalse(nvp.equals(null));
+        assertFalse(nvp.equals(new Object()));
+        assertTrue(nvp.equals(nvp));
+    }
+}

src/test/java/org/jvnet/jenkins/plugins/nodelabelparameter/parameterizedtrigger/AllNodesForLabelBuildParameterFactoryUnitTest.java

@@ -2,6 +2,7 @@
 
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.contains;
+import static org.junit.Assert.assertEquals;
 
 import hudson.EnvVars;
 import hudson.Launcher;
@@ -92,6 +93,28 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen
         assertThat(executed, contains(Boolean.TRUE));
     }
 
+    @Test
+    public void testGetDisplayName() {
+        AllNodesForLabelBuildParameterFactory.DescriptorImpl descriptor =
+                new AllNodesForLabelBuildParameterFactory.DescriptorImpl();
+
+        assertEquals("All Nodes for Label Factory", descriptor.getDisplayName());
+    }
+
+    @Test
+    public void testIsIgnoreOfflineNodes() {
+        AllNodesForLabelBuildParameterFactory factory =
+                new AllNodesForLabelBuildParameterFactory("name", "label", true);
+
+        // Assert that the ignoreOfflineNodes flag is set to true
+        assertEquals(true, factory.isIgnoreOfflineNodes());
+
+        factory = new AllNodesForLabelBuildParameterFactory("name", "label", false);
+
+        // Assert that the ignoreOfflineNodes flag is set to false
+        assertEquals(false, factory.isIgnoreOfflineNodes());
+    }
+
     public static void noMatchingNodeShouldYieldSameLabel(
             final AllNodesForLabelBuildParameterFactory dummyNodesFactory,
             AbstractBuild<?, ?> build,

src/test/java/org/jvnet/jenkins/plugins/nodelabelparameter/parameterizedtrigger/NodeLabelBuildParameterTest.java

@@ -266,4 +266,11 @@ public void testValidateBuildNoExceptionIfConcurrentBuildsAllowed() throws Excep
 
         j.jenkins.removeNode(slave);
     }
+
+    @Test
+    public void testGetDisplayName() {
+        NodeLabelBuildParameter.DescriptorImpl descriptor = new NodeLabelBuildParameter.DescriptorImpl();
+
+        Assert.assertEquals("NodeLabel parameter", descriptor.getDisplayName());
+    }
 }

src/test/java/org/jvnet/jenkins/plugins/nodelabelparameter/parameterizedtrigger/NodeListBuildParameterFactoryTest.java

@@ -99,6 +99,26 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen
         assertThat(executed, contains(Boolean.TRUE));
     }
 
+    @Test
+    public void testDoCheckNodeListString() throws Exception {
+        NodeListBuildParameterFactory.DescriptorImpl descriptor = new NodeListBuildParameterFactory.DescriptorImpl();
+
+        FreeStyleProject projectA = j.createFreeStyleProject("projectA");
+
+        Item parent1 = j.jenkins.getItem("projectA");
+        Item parent2 = projectA.asItem();
+
+        // Validate the FormValidation.ok() case
+        FormValidation okValidation = descriptor.doCheckNodeListString(parent2, "node1");
+
+        Assert.assertEquals(okValidation.kind, FormValidation.Kind.OK);
+
+        // Validate the FormValidation.error() case if node is null
+        FormValidation errorValidation = descriptor.doCheckNodeListString(parent1, null);
+
+        Assert.assertEquals(errorValidation.kind, FormValidation.Kind.ERROR);
+    }
+
     private TriggerBuilder createTriggerBuilder(AbstractProject<?, ?> project, AbstractBuildParameterFactory factory) {
         TriggerBuilder tBuilder = new TriggerBuilder(new BlockableBuildTriggerConfig(
                 project.getName(),