Skip to content

Commit

Permalink
fix(spotbugs): Primitive field selectCustomScmCommentPrefix is public…
Browse files Browse the repository at this point in the history
… and set from inside the class.

It makes it too exposed. Consider making it private to limit external accessibility. [org.jvnet.hudson.plugins.m2release.M2ReleaseBuildWrapper] At M2ReleaseBuildWrapper.java:[line 93] PA_PUBLIC_PRIMITIVE_ATTRIBUTE
  • Loading branch information
gounthar committed Feb 21, 2024
1 parent 9b48dd3 commit 48593c1
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public class M2ReleaseBuildWrapper extends BuildWrapper {
private String releaseEnvVar = DescriptorImpl.DEFAULT_RELEASE_ENVVAR;
private String releaseGoals = DescriptorImpl.DEFAULT_RELEASE_GOALS;
private String dryRunGoals = DescriptorImpl.DEFAULT_DRYRUN_GOALS;
public boolean selectCustomScmCommentPrefix = DescriptorImpl.DEFAULT_SELECT_CUSTOM_SCM_COMMENT_PREFIX;
private boolean selectCustomScmCommentPrefix = DescriptorImpl.DEFAULT_SELECT_CUSTOM_SCM_COMMENT_PREFIX;
private boolean selectAppendHudsonUsername = DescriptorImpl.DEFAULT_SELECT_APPEND_HUDSON_USERNAME;
public boolean selectScmCredentials = DescriptorImpl.DEFAULT_SELECT_SCM_CREDENTIALS;

Expand Down

0 comments on commit 48593c1

Please sign in to comment.