Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-66079] Allow setting hookUrl from the global configuration page #376

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

franknarf8
Copy link

@franknarf8 franknarf8 commented Apr 5, 2024

This PR fixes JENKINS-66079.

It is actually not possible to set hookUrl from the global config page since 2019. The hookUrl setter is not recognized by the bindJSON code since the input parameter type change from URL to String.

The following test crashes with the code prior to my changes :

@Test
public void hookUrlShouldHaveAWriteMethod() throws Throwable {
    PropertyDescriptor hookUrlWrite = PropertyUtils.getPropertyDescriptor(
            new GitHubPluginConfig(new ArrayList<>()), "hookUrl"
    );
    assertNotNull("hookUrl write method should exits", hookUrlWrite.getWriteMethod());
}

Testing done

Re-enabled and modernized the test suite regarding global configs.

Submitter checklist

Preview Give feedback

Frank Genois added 2 commits April 5, 2024 16:21
- Broken since 2019 : 4be509e
- The hookUrl setter is not recognized by the bindJSON code since the input
  parameter type change from URL to String

The following test crashes with the previous code :
```
@test
public void hookUrlShouldHaveAWriteMethod() throws Throwable {
    PropertyDescriptor hookUrlWrite = PropertyUtils.getPropertyDescriptor(
            new GitHubPluginConfig(new ArrayList<>()), "hookUrl"
    );
    assertNotNull("hookUrl write method should exits", hookUrlWrite.getWriteMethod());
}
```
@franknarf8 franknarf8 changed the title JENKINS-66079 Allow setting hookUrl from the global configuration page [JENKINS-66079] Allow setting hookUrl from the global configuration page Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant