Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore compatibility for GitSampleRepoRule #1626

Merged

Conversation

MarkEWaite
Copy link
Contributor

Restore compatibility for GitSampleRepoRule

I forgot that there are other consumers of the Git plugin test suite.

Plugin BOM automated tests detected the problem.

Testing done

mvn clean verify passes and the previous implementation is restored.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

I forgot that there are other consumers of the Git plugin test suite.

Plugin BOM automated tests detected the problem.
@MarkEWaite MarkEWaite requested a review from a team as a code owner August 5, 2024 01:38
@MarkEWaite MarkEWaite added the tests Automated test addition or improvement label Aug 5, 2024
@MarkEWaite MarkEWaite enabled auto-merge (squash) August 5, 2024 01:51
@MarkEWaite MarkEWaite merged commit 29a5456 into jenkinsci:master Aug 5, 2024
17 checks passed
@MarkEWaite MarkEWaite deleted the restore-test-api-compatibility branch August 11, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant