Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace multiple images with a single image #1539

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

MarkEWaite
Copy link
Contributor

Replace multiple images with a single image

The multi-image layout renders correctly on github.com but does not render correctly on plugins.jenkins.io. The technique that was being used is uncommon for Jenkins plugins. Much better to use the layout of a single image that is approximately the same width as the other images included in the page.

Remove unused images

Checklist

  • I have read the CONTRIBUTING doc
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Documentation

The multi-image layout renders correctly on github.com but does not
render correctly on plugins.jenkins.io.  The technique that was being
used is uncommon for Jenkins plugins.  Much better to use the layout of
a single image that is approximately the same width as the other images
included in the page.
@MarkEWaite MarkEWaite requested a review from a team as a code owner December 22, 2023 13:57
@MarkEWaite MarkEWaite added the documentation Improvements or additions to documentation label Dec 22, 2023
@MarkEWaite MarkEWaite merged commit 5311006 into jenkinsci:master Dec 22, 2023
1 of 3 checks passed
@MarkEWaite MarkEWaite deleted the fix-docs-image branch December 22, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant