Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Spring security API instead of Acegi security #1520

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Use Spring security API instead of Acegi security #1520

merged 5 commits into from
Nov 10, 2023

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Oct 26, 2023 •
edited by MarkEWaite
Loading

Use Spring security API instead of Acegi security

Checklist

  • I have read the CONTRIBUTING doc
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Use modern API instead of the deprecated API

@github-actions github-actions bot added the dependencies Dependency related change label Oct 26, 2023
@Vlatombe Vlatombe mentioned this pull request Oct 26, 2023
Merged
jglick
jglick reviewed Nov 1, 2023
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@jglick jglick marked this pull request as ready for review November 1, 2023 21:22
@jglick jglick requested a review from a team as a code owner November 1, 2023 21:22
@github-actions github-actions bot removed the dependencies Dependency related change label Nov 6, 2023
@MarkEWaite MarkEWaite changed the title jep-227 downstream usage Use Spring security API instead of Acegi security Nov 6, 2023
@MarkEWaite MarkEWaite added the enhancement Improvement or new feature label Nov 6, 2023
MarkEWaite
MarkEWaite approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

I used an incremental build to run authenticated requests to Assembla, Beanstalk,. Bitbucket, Gitea, GitHub, GitLab, and Microsoft Visual Studio Online. All worked as expected.

@MarkEWaite MarkEWaite enabled auto-merge (rebase) November 10, 2023 04:33
@MarkEWaite MarkEWaite merged commit 11ae2dd into jenkinsci:master Nov 10, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
enhancement Improvement or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vlatombe @jglick @MarkEWaite