Use poll env when checking for ls-remote branches. #1511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core issue is that params are not resolved until the start of the build (i.e. not valid in the Polling context).
The
git ls-remote
code-path uses an empty env when checking for branches - which means params in a branch spec don't get resolved.I have updated the code to use the
pollEnv
variable when evaluating these params - as these .Some additional background - we have tried the workaround of setting 'Force workspace when polling'. This seems to fix the issue for permanent nodes, but we use a lot of EC2 nodes where it breaks once the node that last ran a job gets culled.
Checklist
Types of changes