Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix erratic GitStatusTest #1480

Merged
merged 7 commits into from
Jul 8, 2023
Merged

Fix erratic GitStatusTest #1480

merged 7 commits into from
Jul 8, 2023

Commits on Jul 8, 2023

  1. Fix random GitStatusTest failures 

    Test already had code that waits for jobs to complete on Windows.
The improved job leak detection that was implemented in the Jenkins
test harness will sometimes show the same conditions on Unix builds.
Wait for jobs to complete on Windows and on Unix.
    @MarkEWaite
    MarkEWaite committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    2e6fbe0 View commit details
    Browse the repository at this point in the history

  2. Remove non JenkinsRule tests to simplify cleanup

    @MarkEWaite
    MarkEWaite committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    16a3597 View commit details
    Browse the repository at this point in the history

  3. Move simple GitStatusTest items to new class 

    No need to complicate GitStatusTest with the test methods that do not
require a JenkinsRule.  Use a simpler test structure and a simpler test
file for the GitStatusTest assertions that do not require a JenkinsRule.
    @MarkEWaite
    MarkEWaite committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    85e1bdf View commit details
    Browse the repository at this point in the history

  4. Assert that the "all" view must exist

    @MarkEWaite
    MarkEWaite committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    b6b3851 View commit details
    Browse the repository at this point in the history

  5. Report a message if no jobs found for wait loop 

    Not an error, but surprising based on my testing.  None of my test
machines are fast enough to complete all the jobs without needing any
time for waiting.
    @MarkEWaite
    MarkEWaite committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    5e398ac View commit details
    Browse the repository at this point in the history

  6. Replace Hudson with Jenkins in comments

    @MarkEWaite
    MarkEWaite committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    37788ba View commit details
    Browse the repository at this point in the history

  7. Remove unused imports

    @MarkEWaite
    MarkEWaite committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    01dd5fe View commit details
    Browse the repository at this point in the history