Feature: Option to report success to PR when build is not triggered #739
+183
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored out a create commit status function. Added option to report success if not pertinent.
|
@MaitreyaBuddha if #632 is is fine for @samrocketman I think we can just merge the other one. All good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of #632 That PR was approved but failed build due to build machine reaping. I no longer have access to the original repo to rebase & force rebuild. I no longer work for Leanplum.
I created this new PR to run the build again. Please approve and we can get this in!
Pro Tip: If you're crazy about security, feel free to compare this branch with the approved Leanplum branch and you will see no differences.