Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix popup styles #157

Merged
merged 3 commits into from
Oct 25, 2019
Merged

Fix popup styles #157

merged 3 commits into from
Oct 25, 2019

Conversation

jarst
Copy link
Contributor

@jarst jarst commented Oct 23, 2019

  1. Replace inline styles with class
  2. Make the popup size more flexible so it can adapt to window size
  3. Allow overflow scrolls (if table is larger than current size of popup)

This pull request should fix #145 & #153.

I have tested it on Jenkins ver. 2.190.1

@willwh
Copy link
Member

willwh commented Oct 25, 2019

@jarst thanks for this :) I merged one of your older PRs that's introduced a conflict with this. If you can get this tidied up, once we merge it, and #151 - we can transfer the repo and cut a new release. Thanks for your help!

@jarst
Copy link
Contributor Author

jarst commented Oct 25, 2019

Should be fine now :)

@willwh willwh merged commit 033dd6a into jenkinsci:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Custom Columns
2 participants