Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally allow image resolution by name #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oneingan
Copy link

this enables a use case where one would continuously update the image and re-create it as a new snapshot, causing the id to constantly change but the name to be persistent. since ordinarily name is a really poor way to resolve images, in particular also because we always need to talk to the api to get the actual image, this entire feature is limited to user images rather than all images. specifically this also lessens the API work we need to do.

the template config has a new checkbox to enable this feature, which then prompts a reload of the image combobox to only include user images (and at the same time the values in the model are changed from slugOrIds to names)

at provisioning time we then need to pass a bit more context along so as to resolve accordingly in newImage()

Testing done

Submitter checklist

Preview Give feedback

this enables a use case where one would continuously update the image
and re-create it as a new snapshot, causing the id to constantly change
but the name to be persistent. since ordinarily name is a really poor
way to resolve images, in particular also because we always need to talk
to the api to get the actual image, this entire feature is limited to
user images rather than all images. specifically this also lessens the
API work we need to do.

the template config has a new checkbox to enable this feature, which
then prompts a reload of the image combobox to only include user images
(and at the same time the values in the model are changed from slugOrIds
to names)

at provisioning time we then need to pass a bit more context along so as
to resolve accordingly in newImage()
@halkeye
Copy link
Member

halkeye commented Sep 21, 2023

oh man, i so rarely use jenkins anymore, but i had so much trouble testing the other PR because I have way too many images.

@oneingan
Copy link
Author

Oh! thanks for your reply. If you are not in charge anymore maybe you can put this plugin in adoption phase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants