Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkbox for Builder to fail deployment when there are no artifacts. #11

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

genericpenguin
Copy link

The ArtifactDeployer Build step does not have an option to fail the build when there are no artifacts, which the Publishing step does have. These changes add the same checkbox to the Build step. I have pretty much copy pasted the code from the ArtifactDeployerPublisher class and updated the jelly file accordingly. The code compiles and I have tested it on a local instance of Jenkins (fails the build when there are no files and the checkbox is active, does not fail when there are no files and the checkbox is inactive).

@genericpenguin
Copy link
Author

Hi @seanturner83,

Would you be able to have a peek at this when you have a chance? Sorry, I can't add reviewers (I might have sporked the procedure for pull requests in to Jenkins plugins because noob).

Sven Schott

@seanturner83 seanturner83 self-assigned this Oct 9, 2017
@seanturner83
Copy link
Contributor

LGTM, and CI has completed successfully - I'll test the .hpi later and merge, then I just need to find time to set up the faffy release process on a new laptop! Wonder if we got unblocked by the security team yet?

@genericpenguin
Copy link
Author

Just a quick ping to see if this is still on the cards. I would love to see it go through just so I can have the official release on my Jenkins instead of my local build. :)

@genericpenguin
Copy link
Author

Sorry, just another ping to see if this will be merged soon. If there's anything I can do to help, please let me know.

@genericpenguin
Copy link
Author

Hey @seanturner83
Just another quick ping to see what the status is with the PR. If there is anything you need me to do (or would like me to do), please let me know.

@MarkEWaite MarkEWaite added the feature Enhancement label Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants