Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI validation for the release drafter configuration #39

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Add CI validation for the release drafter configuration #39

merged 2 commits into from
Apr 23, 2021

Conversation

PierreBtz
Copy link
Contributor

This is WIP to explore configuration validation by CI. It should address #21 .

@PierreBtz PierreBtz mentioned this pull request Jul 23, 2020
Closed
2 tasks
oleg-nenashev
oleg-nenashev approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good though I have not tested it

Jenkinsfile Show resolved Hide resolved
scripts/validateReleaseDrafterConfiguration.sh Show resolved Hide resolved
scripts/validateReleaseDrafterConfiguration.sh Show resolved Hide resolved
@oleg-nenashev
Copy link
Member

@PierreBtz do you think this is ready to go?

@PierreBtz
Copy link
Contributor Author

@oleg-nenashev I don't know, I may be nitpicking but I would like to have release-drafter/release-drafter#600 to directly depend on an officialy released schema instead of some commit in github. That being said the upstream PR is not moving so I'm happy to merge with the TODO and fix later when my upstream PR is merged.

@jetersen
Copy link
Member

release-drafter/release-drafter#600 is merged

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Oct 17, 2020 via email

@PierreBtz
Copy link
Contributor Author

@jetersen thanks a lot, is there any release planned soon for release drafter?

@jetersen
Copy link
Member

The schema is read from master branch

@PierreBtz
Copy link
Contributor Author

schema store points to a release tag. If I don't point to the same commit, it means that the IDE validation won't match the build validation.
If you don't have a release planned soon, it's ok, I'll keep pointing to a commit for now with a TODO.

@jetersen
Copy link
Member

I'll look into releasing a new version later today.

@PierreBtz
Copy link
Contributor Author

That's great! Thanks a lot :)

@jetersen
Copy link
Member

😢 Schemastore changed the URLs... SchemaStore/schemastore#1297

@PierreBtz
Copy link
Contributor Author

MMhh I see, thanks for looking into it, take your time as far as this PR is concerned this is not urgent at all.

@PierreBtz PierreBtz marked this pull request as ready for review April 23, 2021 10:26
@PierreBtz
Copy link
Contributor Author

I somehow missed the schema store reverted their change and is now properly using the master branch. This means we are all set here, this should be ready to merge @jetersen @oleg-nenashev

oleg-nenashev
oleg-nenashev approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections, thanks!
I am not sure the node label will always contain cURL, but it is quite plausible

@oleg-nenashev oleg-nenashev merged commit 4a78b2f into jenkinsci:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PierreBtz @oleg-nenashev @jetersen