fix: allow cluster deletion (terraform-google-jx#233)

[tgelpi]

Description

Beginning with Terraform's Google provider version 5.0.0+, container clusters deletion protection defaults to true which prevents the terraform destroy command from deleting the cluster. To provide a mechanism for overriding this protection, a new TF variable delete_protect is introduced and will be used to set the deletion_protection attribute for the google_container_cluster resource.

Which issue this PR fixes

#233

Release notes

You must explicitly set deletion_protection=false (and run terraform apply to write the field to state) in order to destroy a cluster. It is recommended to not set this field (or set it to true) until you're ready to destroy.

[jenkins-x-bot]

Hi @tgelpi. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[tgelpi]

Not sure if this is the correct thing to do but here goes...
/assign @jstrachan

[msvticket]

/ok-to-test

[msvticket]

/approve

[jenkins-x-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [msvticket]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment