-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use tekton pipeline remote resolution #51
base: master
Are you sure you want to change the base?
feat: use tekton pipeline remote resolution #51
Conversation
Lighthouse is definitely a big blob and splitting it could be a good direction. By the way regarding splitting up the Lighthouse I finally started a PoC to create a SCM feedback (ChatOps) integration, based on Jenkins X's go-scm. Having a plan to stablize the core API, freeze it, document well, so it could be used as a library to build integrations with Tekton, Argo Workflows etc. |
It does sound like a good proposal. Do I understand you correctly that you think it is possible to make this new jx3-git resolver so that t will work as a drop in replacement (with new features) to the implementation in lighthouse? Without any changes to the pipelines or the pipeline catalog I mean. Could you move the markdown file in the proposal so that the file structure matches the one for the existing proposals? |
To check: if the Tekton Controller validation webhook would allow to submit |
Signed-off-by: JordanGoasdoue <[email protected]>
51ff3db
to
e183838
Compare
@msvticket, done it's moved to proposals. The use case I had in mind when writing this proposal was the remote pipeline If all of this is possible, we would still need to add So also to check after what proposed @keskad , is the possibility to run PipelineRun with I will ask in the tekton slack If it's not possible, then we can discuss with Tekton and see the best approach to just make this work officially from Tekton Controller. |
I was thinking about it, regarding the possibilities, I see now that:
Is this a correct scope? |
Yes exactly Lighthouse would just search PipelineRun through the TriggerConfig, and then just apply it without resolving anything. Then the PipelineRun would be resolved by the jx3-git resolver, even if it's a single PipelineRun or with remote ref to Pipeline / Task But if it's not possible to have on a PipelineRun a resolver without specifying pipelineRef / taskRef, we would be stuck |
I think that removing all of the uses: spec is required for 0.41.0, as it creates a lot of problems as the way that jenkins-x does uses, does not pass the validation that tekton has now added. Instead of adding a bunch of fluff to pass the validation, I figured let's just go ahead with this. We're going to build a migrator cli or something similar within jx-pipeline so that we can convert uses to tektons TaskRefs. But we'll have to move away from I believe that this drops a lot of maintaince from jenkins x and means that we can utilise all of the upstream features from Tekton without massive modification of jenkins x in future |
Yes this is too much of a headache to maintain this tekton fork, difficult to maintain, the best is to design our Pipelines another way in order to use all the tekton features without trouble. the atomicity would be on task and not step, this is not that bad, maybe some copy paste between tasks but it's fine. |
But tasks are executed as separate pods so using a shared workspace becomes more complicated, right? But as long as the migration tool you are working on Tom handles this I suppose this is fine. |
@msvticket, there is a shared workspace still, it's just passed around as a PVC. They've got some affinity magic to make it quick to mount |
@tomhobson @JordanGoasdoue Is this still the route you want to continue on? |
The goal is to create our own Jx3-Git Resolver from Tekton Pipeline Remote Resolution to be able to use Remote Pipeline / Task from Git inside our PipelineRuns with the
image: uses:sourceURI
inheritance working. All this logic could then be removed from the WebHook/ChatOps Lighthouse that could be more focused on Webhook / ChatOps thingsWhat do you think ? @msvticket @ankitm123 @tomhobson @babadofar @rajatgupta24