fix: Helmfile promote config per env

[cameronbraid]

The .jx/promote.yaml file is unusable as it overrides the namespace and helmfile rule for any promotion in the cluster repo

This PR fixes this by configuring the helmfile promotion rule per environment

For example You add a file helmfiles/foo/promote.yaml

apiVersion: promote.jenkins-x.io/v1alpha1
kind: HelmfilePromote
spec:
  keepOldVersions:
  - dev/myapp

Then the spec is merged into the HemlfileRule which then functions as it did before

I also simplified the tests to only test the case where HelmfilePromote is used

I set this up as a draft since it introduces a new API kind : HelmfilePromot which would need to be moved into the api package

[jenkins-x-bot-test]

Hi @cameronbraid. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[jenkins-x-bot-test]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rajdavies
You can assign the PR to them by writing /assign @rajdavies in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarqubecloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
18.0% Duplication