Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stats.jenkins.io): override the locations to avoid 200 for 404 errors #5720

Merged

Conversation

smerle33
Copy link
Contributor

@smerle33 smerle33 commented Sep 20, 2024

as per jenkins-infra/helpdesk#4132 (comment) and jenkins-infra/helpdesk#4291

lets defined manual locations to avoid 200 errorcode for 404

@smerle33 smerle33 changed the title feat(stats.jenkins.io): override the locations to avoid 200 for 404 e… feat(stats.jenkins.io): override the locations to avoid 200 for 404 errors Sep 20, 2024
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem that scaleable, any new routes will have to be added here and it will be easily missed.

Would it be possible to do this in the inverse so its only not enabled for the actual static file?

@smerle33 smerle33 marked this pull request as draft September 20, 2024 08:05
@smerle33
Copy link
Contributor Author

This doesn't seem that scaleable, any new routes will have to be added here and it will be easily missed.

Would it be possible to do this in the inverse so its only not enabled for the actual static file?

very good point, let me reverse the logic

@smerle33
Copy link
Contributor Author

as per https://github.com/jenkins-infra/stats.jenkins.io/pull/168/files I reverse the logic to handle 404 only on those path:

https://stats.jenkins.io/pluginversions
https://stats.jenkins.io/plugin-installation-trend
https://stats.jenkins.io/jenkins-stats

@smerle33 smerle33 marked this pull request as ready for review September 20, 2024 08:26
@smerle33 smerle33 merged commit 7dbb6d0 into jenkins-infra:main Sep 20, 2024
6 checks passed
@smerle33 smerle33 deleted the stats.jionginx-website/locations branch September 20, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants