-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Unix Domain Sockets in Pomerium Reverse Proxy #7772
base: master
Are you sure you want to change the base?
Added support for Unix Domain Sockets in Pomerium Reverse Proxy #7772
Conversation
@biru-codeastromer Are you sure the communication goes through unix sockets and not the 8080 TCP port? I'd expect unix:///run/jenkins/jenkins.socket to come up in the config instead of http://jenkins:8080, but I have no experience with Pomerium. @cmo-pomerium could you please review this? |
Thank you for your observation, @zbynek Sir! I initially configured the route to use
Due to this, I reverted to using If this fallback behavior is acceptable, I will document it explicitly in the PR. However, I would appreciate further input, especially from @cmo-pomerium, to confirm whether this is an expected limitation or if there's a recommended workaround to enable Unix domain socket communication. Also Sir @kmartens27 may you please review and guide how to improve this .Thanks! |
Hi Sir @kmartens27 , so as of now ,I should wait for @cmo-pomerium review before proceeding any further? |
We would need 100% certainty that the process is correct before adding it to the documentation. Until we get that confirmation then the PR will not be merged. In that spirit @biru-codeastromer I would hold off from proceeding further. |
Okay @kmartens27 Sir , thanks for the confirmation ! |
Fixes #6893
Changes Made:
config.yaml
anddocker-compose.yaml
in the documentation of unix domain sockets part to demonstrate the new configuration.Testing Done:
1. Initial Setup:
docker-compose.yaml
with Jenkins and Pomerium configurations.http://localhost:8080
.2. Pomerium Configuration:
config.yaml
with placeholders for sensitive information.config.yaml
.3. Integration and Running Services:
docker-compose.yaml
to include Pomerium, linked with Jenkins using Unix domain sockets.https://jenkins.localhost.pomerium.io
.4. JWT Authentication:
5. Verification:
https://verify.localhost.pomerium.io
.6. Authorization Testing:
7. Functionality Testing:
Please review and provide feedback.
Additional note -
Removed the version field from docker-compose.yaml as it is no longer required with newer versions of Docker Compose and caused errors during local testing.