Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4564] Restructure Security section #4612
base: master
Are you sure you want to change the base?
[4564] Restructure Security section #4612
Changes from 9 commits
9703d7b
6c727c3
8163c74
a604ac6
708997b
e68d0ad
dcad943
d568df4
721f907
0ffb510
7fb49ce
bdf825b
033a397
db5a03e
6639fec
5e0b503
5f4e5d4
557c68d
0eeeb0b
70098e6
da01b25
6f81a40
b8d7c1e
28e443a
e7f5165
f7d4100
b1519f3
6109f6a
52b9f64
b750b91
228fb0f
1a08475
c6eff48
23c078f
27429db
9f431b8
184cd91
cd21cad
35b4ed8
87c2ab8
808d2aa
b061d8d
7f61450
0bc82cd
f6096fd
384fe9d
ca895cd
ba6730b
9849ee6
27afddd
9ad1afa
c545ed7
dd7768a
bc3212c
aec1a09
2c46b5a
d512ff7
1609c80
2549d42
fb96a9e
8b9af00
ed0e597
89adbc6
d5b6325
1d349e8
4b4ced3
e92c6f7
b886850
be0f0aa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already a potential problem, as pipeline authors can configure their pipelines to run on
node('master || built-in')
and suddenly other stuff is running. https://plugins.jenkins.io/job-restrictions/ exists, but out of the box, only zero executors can prevent that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole sub-section is being merged with the info in the controller-isolation.adoc file. See #4635 . I will modify the note in that PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See lines 45ff in the controller-isolation.adoc file. I did not include the syntax that Pipeline authors can use to access a labeled executor. I figured we didn't want to make this a how-to manual, right?