Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added information about Eclipse Plugin #1339

Merged
merged 3 commits into from
Jan 24, 2018

Conversation

de-jcup
Copy link
Contributor

@de-jcup de-jcup commented Jan 23, 2018

- added information about Jenkins Editor plugin at https://marketplace.eclipse.org/content/jenkins-editor 
- the plugin is OSS and has Apache 2.0 License and is hosted at https://github.com/de-jcup/eclipse-jenkins-editor
Copy link
Contributor

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would create a separate section for "IDE Integrations" and put it there. There is also a small IDEA plugin

Copy link

@paulvi paulvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this adds new section, it can be moved anytime

@paulvi
Copy link

paulvi commented Jan 24, 2018

@oleg-nenashev Can you point to "small IDEA plugin" ?
Then other PR should be to add other IDE, and organize under "IDE Integrations"

- added section "IDE integraations" as suggested
- updated little typo
@de-jcup
Copy link
Contributor Author

de-jcup commented Jan 24, 2018

@paulvi : sorry I committed the change before I have seen you have already approved the issue...

@oleg-nenashev
Copy link
Contributor

@de-jcup https://plugins.jetbrains.com/plugin/10127-jenkinsfile-idea-plugin
I would not say this plugin offers much functionality && it definitely breaks GDSL integration.

Maybe it rather makes sense linking posts like https://st-g.de/2016/08/jenkins-pipeline-autocompletion-in-intellij

@paulvi
Copy link

paulvi commented Jan 24, 2018

@oleg-nenashev It is better to wait author of IDEA plugin to do description.

Anyways, it would be other PR, and after some time as author would notice oliverlockwood/jenkinsfile-idea-plugin#5

@oleg-nenashev
Copy link
Contributor

fine with me

Copy link
Contributor

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝 though maybe it should go after the linter

Moved to after description of features built into Jenkins
@bitwiseman bitwiseman merged commit fbcbb53 into jenkins-infra:master Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants