Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mirrors,get) monitor http to https enforced redirection and use the same pattern for get and mirrors #88

Conversation

dduportal
Copy link
Contributor

Why this change? #85 (comment)

The goal is to monitor the enforced HTTP to HTTPS redirection introduced by the actions in jenkins-infra/helpdesk#2888 (consildating the DNS mirrors.jenkins* to the kubernetes-hosted mirrorbits service, same as get.jenkins.io).

…the same pattern for get and mirrors

Signed-off-by: Damien Duportal <[email protected]>
synthetics_get.tf Outdated Show resolved Hide resolved
Signed-off-by: Damien Duportal <[email protected]>
resource "datadog_synthetics_test" "mirrors_jenkinsci_org" {
type = "api"
request_definition {
method = "GET"
url = "https://mirrors.jenkins-ci.org"
url = "https://mirrors.jenkins-ci.org/debian/jenkins_2.251_all.deb?mirrorlist"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this version have to be updated in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope: a given version must always be available through the mirrors.
The idea is to monitor the whole service (e.g. "does it work as expected?") and not only the HTTP answer. By providing a full URL to an existing file, with the query string parameter mirrorlist, then we expect the HTTP/200 page.
Since mirrorbits does not have the file itself (it is expected to answer an HTTP/3XX redirect to a mirror), an HTTP/200 only means that we have the full-featured service.

=> this was the behavior of the monitor on get.jenkins.io, so this change is to make it coherent (as the 3 domains get.jenkins.io, mirrors.jenkins.io and mirrors.jenkins-ci.org are pointing towards the same service)

@lemeurherve lemeurherve merged commit f0b41d9 into jenkins-infra:main May 27, 2022
@dduportal dduportal deleted the feat/mirrors.jenkins.io-https-redirect branch May 27, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants