Slight testing refactor #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laraconda
commented
Jun 2, 2023
jendrikseipp
requested changes
Jun 7, 2023
|
This failed because the CI is trying to run the style env from tox and its no longer there. Running |
jendrikseipp
requested changes
Jun 10, 2023
Co-authored-by: Jendrik Seipp <[email protected]>
|
Please ping me when I should have another look at this. |
…ipp#687) This can be used to merge one rednotebook directory into another. --------- Signed-off-by: Simon Glass <[email protected]> Co-authored-by: Jendrik Seipp <[email protected]>
It is useful to be able to merge notebooks regularly across multiple machines. The existing script adds the new material again, even if a previous merge already added it. Add a check for this, so that repeated merging will not create lots of duplicate text. Also include a summary of what happened and mention a script dependency. Signed-off-by: Simon Glass <[email protected]>
* Bump pyinstaller from 5.0 to 5.13.1 in /win Co-authored-by: Jendrik Seipp <[email protected]>
Co-authored-by: Jendrik Seipp <[email protected]>
…and preprocessor directives (fixes jendrikseipp#738).
|
I took the liberty of polishing this slightly and merged it. Thanks for your work @laraconda ! |
jendrikseipp
pushed a commit
to laraconda/rednotebook
that referenced
this pull request
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes in this pull request
-Deleting check-style.sh since it was possible to run its commands from tox.
-Updating README with test instructions
-Reducing verbosity when testing translations
Pull request checklist
CHANGELOG.mdincluding my name and issue and/or pull request number.TODO.md.