Fixing bug #537, image filenames and web links are not included in wo… #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cluded in words cloud anymore.
jendrikseipp
requested changes
May 16, 2023
|
I'm thinking about adding small tests for this. I should make a new file in tests/ right? Will tox automatically run it if its there? |
|
Good idea! If it doesn't fit with some other tests that are already there, yes, please add a new test file. Tox will pick it up automatically. |
|
I tried to write a test for this functionality but since the class Cloud takes an instance of journal, I figured it would be complicated to instanciate Journal and insert simple text into it. @jendrikseipp do you think there's an easy way to do it? |
jendrikseipp
requested changes
May 31, 2023
|
I agree that testing this is too complicated. So no need to add a test here. |
|
I'm assuming the ball is in your court. Give me a shout when you want me to review your changes. |
…#703) * Fixing url not recognized when hashtag symbol is followed by slash. Issue jendrikseipp#556 * Adding more cpp directives to hashtag pattern in t2t. Adding comment regarding what each hashtag regex is used for in both files. --------- Co-authored-by: Jendrik Seipp <[email protected]>
…ipp#687) This can be used to merge one rednotebook directory into another. --------- Signed-off-by: Simon Glass <[email protected]> Co-authored-by: Jendrik Seipp <[email protected]>
It is useful to be able to merge notebooks regularly across multiple machines. The existing script adds the new material again, even if a previous merge already added it. Add a check for this, so that repeated merging will not create lots of duplicate text. Also include a summary of what happened and mention a script dependency. Signed-off-by: Simon Glass <[email protected]>
* Bump pyinstaller from 5.0 to 5.13.1 in /win Co-authored-by: Jendrik Seipp <[email protected]>
Co-authored-by: Jendrik Seipp <[email protected]>
…and preprocessor directives (fixes jendrikseipp#738).
|
Thanks @laraconda ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rds cloud anymore.
Bug: #537
Summary of the changes in this pull request
Pull request checklist
CHANGELOG.mdincluding my name and issue and/or pull request number.TODO.md.