Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAT-623 sync/async receiver openhim import #180

Merged
merged 9 commits into from
Dec 1, 2022
Merged

PLAT-623 sync/async receiver openhim import #180

merged 9 commits into from
Dec 1, 2022

Conversation

Mark-Labuschagne
Copy link
Contributor

@Mark-Labuschagne Mark-Labuschagne commented Nov 25, 2022 •
edited
Loading

@Mark-Labuschagne Mark-Labuschagne changed the base branch from main to PLAT-620-add-jempi-services November 25, 2022 09:06
@Mark-Labuschagne
Copy link
Contributor Author

@rcrichton please have a look at the url patterns for the sync/async receivers - I don't know what they're actually supposed to be.

Base automatically changed from PLAT-620-add-jempi-services to main November 29, 2022 06:55
@Mark-Labuschagne Mark-Labuschagne marked this pull request as ready for review November 29, 2022 06:57
Mark-Labuschagne and others added 4 commits November 29, 2022 12:04
@Mark-Labuschagne @nour-borgi
Update client-registry-jempi/importer/openhim/openhimConfig.js
85f36e5 
Co-authored-by: Nour Borgi <[email protected]>
@Mark-Labuschagne @nour-borgi
Update client-registry-jempi/swarm.sh
d832424 
Co-authored-by: Nour Borgi <[email protected]>
@Mark-Labuschagne
removed obselete defaults
524e64a 
the defaults there would never be accessed, and should always have set
values in their docker-compose files
PLAT-623
@Mark-Labuschagne
linting
6093a50
@Mark-Labuschagne Mark-Labuschagne marked this pull request as draft November 29, 2022 10:23
@Mark-Labuschagne Mark-Labuschagne marked this pull request as ready for review November 29, 2022 10:23
rcrichton
rcrichton requested changes Nov 30, 2022
View reviewed changes
Copy link
Member

@rcrichton rcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just on comment.

client-registry-jempi/importer/openhim/openhim-import.json Outdated Show resolved Hide resolved
@Mark-Labuschagne Mark-Labuschagne marked this pull request as draft November 30, 2022 09:21
@Mark-Labuschagne Mark-Labuschagne marked this pull request as ready for review November 30, 2022 09:22
rcrichton
rcrichton approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@rcrichton rcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rcrichton rcrichton merged commit 9da703c into main Dec 1, 2022
@rcrichton rcrichton deleted the PLAT-623-sync-receiver-openhim-import branch December 1, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nour-borgi nour-borgi nour-borgi approved these changes

@rcrichton rcrichton rcrichton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mark-Labuschagne @rcrichton @nour-borgi