Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add detail page link in context menu #6332

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

othmar52
Copy link

Changes
Currently it is impossible to navigate to the detail page of a playlist item.
this PR adds a detail page link to items context menu:

image

Issues
no known iussues

@othmar52 othmar52 requested a review from a team as a code owner November 20, 2024 10:49
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Nov 20, 2024

Cloudflare Pages deployment

Latest commit 2616432
Status ✅ Deployed!
Preview URL https://ace885b0.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/components/itemContextMenu.js Show resolved Hide resolved
@dmitrylyzo dmitrylyzo added enhancement Improve existing functionality or small fixes ui & ux This PR or issue mainly concerns UI & UX labels Nov 20, 2024
src/strings/de.json Outdated Show resolved Hide resolved
src/strings/en-gb.json Outdated Show resolved Hide resolved
src/components/itemContextMenu.js Outdated Show resolved Hide resolved
@othmar52
Copy link
Author

othmar52 commented Nov 21, 2024

@dmitrylyzo thanks for your feedback!

I've realized I forgot to hide the "Details" link when the user is already on the details page. I tried searching the source for similar appRouter conditions but couldn't find anything relevant.

Could you point me in the right direction?

EDIT: i figured it out myself: 2616432

Copy link

sonarcloud bot commented Nov 21, 2024

@dmitrylyzo
Copy link
Contributor

@dmitrylyzo thanks for your feedback!

I've realized I forgot to hide the "Details" link when the user is already on the details page. I tried searching the source for similar appRouter conditions but couldn't find anything relevant.

Could you point me in the right direction?

EDIT: i figured it out myself: 2616432

I think it would be better to add an option similar to options.moremediainfo (say itemdetails):

if (item.MediaSources && options.moremediainfo !== false) {

and set it to false here:
return {
item: item,
open: false,
play: false,
playAllFromHere: false,
queueAllFromHere: false,
positionTo: button,
cancelTimer: false,
record: false,
deleteItem: item.CanDelete === true,
shuffle: false,
instantMix: false,
user: user,
share: true
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes ui & ux This PR or issue mainly concerns UI & UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants