Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor getDeviceName() for readability #6319

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactor getDeviceName() for readability #6319

wants to merge 3 commits into from
+31 −32

Commits on Nov 14, 2024

  1. Refactor getDeviceName() for readability 

    Refactored a long if-else into a cleaner, easier to extend mapping
    @kepper104
    kepper104 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f661fc2 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @kepper104 @github-actions
    kepper104 and github-actions[bot] authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    db34040 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Move BrowserName to the top of the file 

    Renamed deviceMappings to BrowserName and moved it under the appName declaration as requested
    @kepper104
    kepper104 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    049c8ed View commit details
    Browse the repository at this point in the history