Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle paths + concurrent requests + black #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

augustobottelli
Copy link

@augustobottelli augustobottelli commented Oct 23, 2021

Hey Jeff!

Just used your scrapper for a personal project and I added a few features + formatting which I wanted to share with you just in case you find them useful!

  • Handle paths from __file __ to avoid hardcoding them (works for MacOS/Windows)
  • Added concurrent requests to API
  • Format with Black

Pd: Thank you very much for your contributions!

Pd2: I should've separated all of those changes in separate PRs but I didn't have much time to do so. If you need me to, just let me know! (especially removing the formatting)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant