Merge pull request #15 from jeffersonfparil/dev

Correcting StudentT distribution df as n-1 from p-1
jeffersonfparil · Jan 23, 2024 · ed4588b · ed4588b
2 parents 1af8856 + ece069a
commit ed4588b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/gwas/mle.rs b/src/gwas/mle.rs
@@ -173,7 +173,7 @@ impl Regression for UnivariateMaximumLikelihoodEstimation {
         if n != n_ {
             return Err(Error::new(ErrorKind::Other, "The number of samples in the dependent and independent variables are not the same size."));
         }
-        let d = StudentsT::new(0.0, 1.0, p as f64 - 1.0).unwrap();
+        let d = StudentsT::new(0.0, 1.0, n as f64 - 1.0).unwrap();
         self.t = Array1::from_elem(p, f64::NAN);
         self.pval = Array1::from_elem(p, f64::NAN);
         for i in 0..p {

diff --git a/src/gwas/ols.rs b/src/gwas/ols.rs
@@ -136,7 +136,7 @@ impl Regression for UnivariateOrdinaryLeastSquares {
         if n != n_ {
             return Err(Error::new(ErrorKind::Other, "The number of samples in the dependent and independent variables are not the same size."));
         }
-        let d = StudentsT::new(0.0, 1.0, p as f64 - 1.0).unwrap();
+        let d = StudentsT::new(0.0, 1.0, n as f64 - 1.0).unwrap();
         self.t = Array1::from_elem(p, f64::NAN);
         self.pval = Array1::from_elem(p, f64::NAN);
         for i in 0..p {