Fix date time conversion #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Further to this, I have checked that Igor assumes that the creation date is in the current timezone |
* and add many more tests * main problem was the handling of daylight saving offsets * a different result is required when offsets are enforced * also added tz to all tests since these are otherwise not reproducible * new dependency timechange is required
* this takes care of all the offset issues
The mandatory ‘Description’ field should give a comprehensive description of what the package does. One can use several (complete) sentences, but only one paragraph. It should be intelligible to all the intended readership (e.g. for a CRAN package to all CRAN users). It is good practice not to start with the package name, ‘This package’ or similar. As with the ‘Title’ field, double quotes should be used for quotations (including titles of books and articles), and single quotes for non-English usage, including names of other packages and external software. This field should also be used for explaining the package name if necessary. URLs should be enclosed in angle brackets, e.g. ‘<https://www.r-project.org>’: see also Specifying URLs.
* see PTN003 * also suppress some warnings when reading pxps * there is still a point that's rather inelegant where we read records of type 8 (packed notebooks) and then ignore them if they look badly formatted * for this I had to use suppressWarnings to avoid the new readChar warning
jefferis
commented
Aug 5, 2024
| res=res-dst_correction | ||
| # this takes care of tz offset differences between the actual date and the origin | ||
| # e.g. because date is during daylight savings (but origin was not) | ||
| res=timechange::time_add(igor_origin, second = dateval) | ||
| res |
There was a problem hiding this comment.
This is the key change it seems. I'm not quite sure why a straight add doesn't do this but ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been longstanding issues with date time conversion associated with
convertIgorDate. The most persistent problems have been with daylight savings dates which seem to be off by an hour on some platforms. However more puzzlingly the package was archived from CRAN because of a failure on macosx arm https://cran-archive.r-project.org/web/checks/2021/2021-10-05_check_results_IgorR.html for a regular date.I think much of this may boil down to differences in R POSIXct handling vs Igor's of time zone differences, but it's been quite frustrating.
Some recent observations from Igor for a timestamp recorded at 10:39 BST indicate that there is still a fundamental problem in BST: