Skip to content

Commit

Permalink
update CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jefferis committed May 28, 2015
1 parent c57068c commit e2aab86
Showing 1 changed file with 30 additions and 13 deletions.
43 changes: 30 additions & 13 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,38 @@
## Test environments
* local OS X install, R 3.1.2
* ubuntu 12.04 (on travis-ci), R 3.1.2
* win-builder (devel and release)
* local OS X install, R 3.2.0
* ubuntu 12.04 (on travis-ci), R 3.2.0
* winbuilder (devel and release)

## R CMD check results
There were no ERRORs or WARNINGs.
There were no ERRORs or WARNINGs on any platform.

There was 1 NOTE:
There were 3 NOTEs on win-builder devel

* checking dependencies in R code ... NOTE
Namespace in Imports field not imported from: 'R6'
http://win-builder.r-project.org/aSRc7wR7Blt3/00check.log

R6 is a build-time dependency.
relating to 3 issues:

## Downstream dependencies
I have also run R CMD check on downstream dependencies of httr
(https://github.com/wch/checkresults/blob/master/httr/r-release). All packages
that I could install passed except:
1. Possibly mis-spelled words in DESCRIPTION:
Wavemetrics (9:16)
ibw (10:53)
pxp (10:24, 12:13)

The first is a company name, the other two are file formats.

2. Found the following assignments to the global environment:
File 'IgorR/R/ReadIgorBinary.R':
assign(WaveName, rval, envir = .GlobalEnv)

This has been discussed in previous submissions and is not a default behaviour
but must be explicitly requested by the user by setting a documented argument
(?read.ibw). The rationale is that some users like to be able to replicate the
behaviour of Igor Pro in which individual records (aka waves) within a single
file are available as individual objects in the user environment. Once again
this must be explicitly requested.

* XYZ:...
3. No repository set, so cyclic dependency check skipped

For information only.

## Downstream dependencies
There are presently no downstream dependencies on CRAN.

0 comments on commit e2aab86

Please sign in to comment.