Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add delete_by_id to AbstractRepository #96

Merged
merged 2 commits into from
Apr 11, 2024
Merged

feat: add delete_by_id to AbstractRepository #96

merged 2 commits into from
Apr 11, 2024

Conversation

jochman
Copy link
Contributor

@jochman jochman commented Mar 20, 2024

I'm missing this command. It's needed for crud applications where I'm getting the ID to delete.

@jochman
Copy link
Contributor Author

jochman commented Apr 11, 2024

@jefersondaniel can I ping you? :)

jefersondaniel
jefersondaniel approved these changes Apr 11, 2024
View reviewed changes
Copy link
Owner

@jefersondaniel jefersondaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jefersondaniel jefersondaniel merged commit 26a6fbe into jefersondaniel:main Apr 11, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Apr 11, 2024
Merged
@jochman jochman deleted the delete-one-by-id branch April 11, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefersondaniel jefersondaniel jefersondaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jochman @jefersondaniel