Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(convert): allow fully offline HTML presentation #440

Merged
merged 10 commits into from
Nov 1, 2024
Merged

Conversation

jeertmans
Copy link
Owner

@jeertmans jeertmans commented May 22, 2024

Closes #438

@jeertmans jeertmans added enhancement New feature or request html-convert Related to converting to HTML slides labels May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.05%. Comparing base (75af26e) to head (debd631).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
manim_slides/convert.py 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
+ Coverage   80.86%   81.05%   +0.18%     
==========================================
  Files          23       23              
  Lines        1866     1884      +18     
==========================================
+ Hits         1509     1527      +18     
  Misses        357      357              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jeertmans and others added 3 commits October 30, 2024 14:01
TODO: check if this is really the case, especially for nested dependencies?

Closes #438
@jeertmans jeertmans merged commit d8acbae into main Nov 1, 2024
40 of 44 checks passed
@jeertmans jeertmans deleted the offline branch November 1, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request html-convert Related to converting to HTML slides
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add --offline option for HTML convert
1 participant