Dotnet 8 Update #187
Merged
Dotnet 8 Update #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree we should release when dotnet 8 goes to GA. We could also drop dotnetcore 3.1 since it went out of support last year. |
|
I think think im through for now. When GA is released we can finalize this PR. |
|
@jediwhale Now that I look over the repo once more, we could also add assembly versioning for this release. I think about a file providing the version or writing the version into build.proj instead of Fitsharp.nuspec. What are your thoughts about that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is intended to add support for dotnet 8. IMO this should only be done after GA of dotnet 8 in November.
How should we organise the work on this? I can supply the new definitions, but can't handle the nuget release.