Make fromRect Optional (and other improvements) #30

SteffeyDev · 2017-06-01T20:22:56Z

This is a usability update with three significant changes:

When no fromRect prop is passed in, the popover scales from the middle of the screen, allowing for more use cases. This is very useful when the button that launches the popover is in a scrollview and may be in different positions, and thus calculating a rectangle would be difficult.
The content view is given a 10px padding from the edges of the screen in all cases. This makes it more visually evident that the popover is floating in front of the screen.
The entire view is now in a modal so that the popover always shows on top (This makes PR Added zIndex to make the popover always display in front of everything #27 not needed, which is better because zIndex is currently unreliable on Android).
Tapping on the content view itself no longer dismisses the popover, only tapping on the background view does. This allows for the use of a scrollview and other types of views in the popover that was not previously possible.

I have found these improvements make this component usable and useful on my iPad.
Note: I do not have an Android tablet to test on, so this would be necessary before merging.

This keeps the popover view from being flush with the edges.

This simply scales the view from the middle when there is no fromRect prop to go off of.

This undoes an odd but unnecessary change I made.

I copied the popover file from uk-agilityworks and modified it in the same way as the other, looking for stability fixes. Turns out, it was the native driver causing the flickering, so turned that off. Now supports Android without crashing.

…screen

This should help clarify a few things that we learned in those issues

Update fromView prop spelling in readme

…show for some reason or doesn't close correctly

added portrait-upside-down to Modal supportedOrientations

… their fromRect if possible'

…ing in

…modals, and new lifecycle props

chore: add typescript definition

SteffeyDev · 2019-06-08T21:08:58Z

Assumed that this repository is dead, now maintaining my own repository: https://github.com/SteffeyDev/react-native-popover-view

SteffeyDev added 4 commits June 1, 2017 00:46

Buffer Popover Off Edges

a6e7aa7

This keeps the popover view from being flush with the edges.

Support for Missing fromRect Prop

09f1ba9

This simply scales the view from the middle when there is no fromRect prop to go off of.

Restore to Initial Animation

03f9ff4

This undoes an odd but unnecessary change I made.

Fixing the Border Radius by enabling overflow="hidden"

891498b

SteffeyDev changed the title ~~No Need for fromRect Prop (and other improvements)~~ Make fromRect Optional (and other improvements) Jun 1, 2017

SteffeyDev and others added 9 commits June 1, 2017 16:37

Update README.md

1ad6abb

Update README.md

37492ca

Support for Changing Display Widths

4165932

Switch to New Popover && Flash Fix

b91cfeb

I copied the popover file from uk-agilityworks and modified it in the same way as the other, looking for stability fixes. Turns out, it was the native driver causing the flickering, so turned that off. Now supports Android without crashing.

Update Version Number

ac8d3fa

View now moves to make space for the keyboard

aadcb8c

Update version

3a19211

Reworked auto direction algorithm, prevention from popover going off …

c55dae8

…screen

Update Version, add needed dependency

478f16e

SteffeyDev force-pushed the master branch from b220058 to 478f16e Compare August 27, 2017 22:02

SteffeyDev added 6 commits August 27, 2017 22:17

Switching underscore to lodash

480914e

Fixes for handling changing displayArea and fromRect

71d2ec8

Adding prop to make showing in a modal optional

4abd6bf

bump version

7ca128e

Updating to support RN 0.48

3b591d5

Bumping version

5d4cc9d

SteffeyDev force-pushed the master branch from 3186359 to 5d4cc9d Compare October 6, 2017 05:57

SteffeyDev added 4 commits October 13, 2017 19:09

Complete refactor for handling displayArea changes dynamically

a3c1459

Fixes bug in adjusting for keyboard height

a240ad6

Temporary fix for issue with useNativeDriver

88e54aa

Adding tests and coverage report, minor changes for stability

51b03d5

SteffeyDev force-pushed the master branch 2 times, most recently from 7a3040b to 1371f6c Compare December 22, 2017 22:40

Updating details for publishing on NPM

6dec71c

SteffeyDev force-pushed the master branch from 1371f6c to 6dec71c Compare December 22, 2017 22:45

SteffeyDev and others added 28 commits November 7, 2018 13:57

Update issue templates

fcc18a7

Update issue templates

bdc6a3c

Adding documentation in response to #28 & #23

5f821a6

This should help clarify a few things that we learned in those issues

Merge branch 'master' of github.com:SteffeyDev/react-native-popover-view

20fdb9f

Potential fix to Issue #21

65bf5b1

Update fromView prop spelling in readme

930c1b6

Merge pull request #31 from drewvolz/readme-spelling

95f5fff

Update fromView prop spelling in readme

Fixing spacing and other errors, fixing for tablets in landscape mode

b26ba5e

removing all default display area skips until I can investigate further

117081b

Merge branch 'master' of github.com:SteffeyDev/react-native-popover-view

195580b

bumping version

7120699

Adding better weird situation handling, for when the popover doesn't …

31839c9

…show for some reason or doesn't close correctly

bumping version

67a2d5e

added portrait-upside-down to Modal supportedOrientations

5195071

Merge pull request #35 from lachlanroche/patch-portraitupsidedown

f471116

added portrait-upside-down to Modal supportedOrientations

Adding more efficient debugging, ability to place popover's inside of…

b82e45e

… their fromRect if possible'

Merge branch 'master' of github.com:SteffeyDev/react-native-popover-view

79b0ba0

bumping version

f040b8f

Fixing issue when isVisible is made false while the popover is animat…

d90cce5

…ing in

Removing unused tests, adding dimension change logging for #34

b0dcaee

Bumping version

ffba514

Version 2 release, with new tooltip mode, display area offset for JS …

d2a30ea

…modals, and new lifecycle props

Fix for android onDismiss

59c187d

Bumping version

640f0c0

chore: add typescript definition

9f473f5

fix: support none View components

327b8ac

Update index.d.ts

a61b19c

Merge pull request #41 from zhigang1992/patch-1

fcf342b

chore: add typescript definition

SteffeyDev closed this Jun 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make fromRect Optional (and other improvements) #30

Make fromRect Optional (and other improvements) #30

SteffeyDev commented Jun 1, 2017 •

edited

Loading

SteffeyDev commented Jun 8, 2019

Make fromRect Optional (and other improvements) #30

Make fromRect Optional (and other improvements) #30

Conversation

SteffeyDev commented Jun 1, 2017 • edited Loading

SteffeyDev commented Jun 8, 2019

SteffeyDev commented Jun 1, 2017 •

edited

Loading