Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis support #323

Merged
merged 9 commits into from
Feb 15, 2017
Merged

Travis support #323

merged 9 commits into from
Feb 15, 2017

Conversation

EvaSDK
Copy link
Collaborator

@EvaSDK EvaSDK commented Feb 15, 2017

As drone.io seems currently dead and was left in a broken state for a while, here is a PR to add support for Travis CI with a few more fixes to unittests tooling.

Known shortcomings of this PR:

  • does not cover PyQt, it should just be a matter of building it and having it in Travis cache but at type changes according to python version in PyQt made me delay trying to support it to a later time.
  • you will have to create your Travis CI account for the badge to work, this is pretty easy and integrated with github login.
  • I could not figure out why the test_set_field_value_simple_file_field test was failing so I had to skip it in Travis runs.

@EvaSDK
Copy link
Collaborator Author

EvaSDK commented Feb 15, 2017

also for the record, not adding python 3.5 right now due to pyside/PySide#132

Using super for python 2 does not work here.
drone.io is being completely revamped it seems but was broken for
months. Maybe get back to it when the new service has landed.
Give an explicit list as seems to be the best practive on pypi and allow sites such as
"Python 3 Wall of Superpowers" and "Python 3 Readiness" to correctly identify
python support of this package.
@EvaSDK
Copy link
Collaborator Author

EvaSDK commented Feb 15, 2017

Fixed a stupid typo that lead to recursion error.

@jeanphix jeanphix merged commit 4ab02d2 into jeanphix:dev Feb 15, 2017
@EvaSDK EvaSDK deleted the travis-support branch March 24, 2017 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants