Clean up dev environment and update database dependencies #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeancochrane
commented
Jun 15, 2024
| environment: | ||
| DJANGO_SECRET_KEY: reallysupersecret | ||
| DJANGO_MANAGEPY_MIGRATE: "on" | ||
| entrypoint: /app/docker-entrypoint.sh | ||
| command: python manage.py runserver 0.0.0.0:8000 | ||
| command: /app/app/docker-entrypoint.sh python manage.py runserver 0.0.0.0:8000 |
There was a problem hiding this comment.
Note for posterity: Something weird was happening with docker-entrypoint.sh where it couldn't actually read in command overrides as arguments when specifying a new command via the CLI. I never really figured it out, but refactoring things such that docker-entrypoint.sh is used in the command rather than the entrypoint fixed the problem, and more closely matches the way I work in development anyway (I don't want to run migrations literally every time I'm running code on the app image).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates some unnecessary Docker files and updates the database stack to the most recent versions of all the packages. We also update
fixtures/mellowroute.jsonto match the most recent dump from prod.Since the prod app doesn't actually use the development Docker resources or fixtures, these changes shouldn't have any effect on prod.