New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix behavior inconsistencies #576

Open

morozkin wants to merge 3 commits into jdg:master from morozkin:fix-inconsistencies

morozkin commented Jun 26, 2019

Hi!

With this PR I fixed several behavior bugs and added a test for these cases.

They are:

If you try to hide a hud without animation, the alpha value for the backgroundView will be equal to 1.0 while it must be equal to 0.0
If you have a hud with an animation type set to MBProgressHUDAnimationZoomIn and you hide this hud animatedly, trying to show it non-animated will end up in having a transform applied to the hub as a result of animated hide which is undesirable behavior.

morozkin added 3 commits

June 26, 2019 15:23


          Fix alpha value that is set to backgroundView on non-animated hide

6cf2e0b


          Reset bezelView transform to identity on non-animated showing

fdd217d


          Add test for checking some use cases

f3a2385

Author

morozkin commented Aug 25, 2019

@matej Can you have a look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet