Fix for deprecation of _drawnLayers in Canvas as of Leaflet 1.4.0 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like it fixes the issue I just observed as well, thank you! Hopefully this can get merged and up to npm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Leaflet 1.4.0 the attribute _drawnLayers no longer exists for Canvas objects (see change log here), so when a map uses the Canvas renderer, ellipse markers throw an exception. The error can be reproduced on the example website by changing the leaflet version to 1.4.0 and adding preferCanvas: true to the map options.
The change checks for _drawnLayers if that doesn't exist checks for _layers, and if tha doesn't exist, throws an error.
This has worked both leaflet<1.4.0 and 1.4.0<=leaflet<=1.8.0 in my testing.