forked from MarlinFirmware/Marlin
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fsr #6
Open
eddieparker
wants to merge
34
commits into
jcrocholl:fsr
Choose a base branch
from
eddieparker:fsr
base: fsr
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fsr #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eturns similar values when it is run again.
…figuration.h be more like "auto configuration". Makes merging easier when I can ignore peoples Configuration.h work.
…s the bed. Will be investigating next.
…iding an example.
… do so before I push to github.
…not using it. I didn't realize, but the Neopixel libraries disable communications temporarily, which is *horrible* for 3D printers that rely on a host program communicating with this. I'll be moving this off to a Trinket next, and exposing a wire interface for my changes.
…efully remember not to push this specific change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Johann:
I've added two bits of functionality to Marlin/your FSR code. Feel free to take all, partial or none:
If defined, the code remains unchanged (reads from thermistor). If undefined, it uses the Z_MIN to detect if the bed height has been hit or not.
For me this is essential as I'm using John Socha's board to send a digital signal (LOW) when hit, and I want to (one day) use my thermistor for the bed as intended.
I find it a bit cleaner - MyConfiguration.h is .gitignored, so people can have their own settings there, but not get stomped over by other people. MyConfiguration.h.example can show people how things can be done, and Configuration.h can be left as the #define logic processor it currently is.
Let me know if you have any questions, suggestions, or violent responses to this. :)
Cheers,
-e-