Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook for other apache plugins #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Thalhammer
Copy link

I'm currently developing an apache plugin (mod_grpcbackend) that allows a grpc server to provide an HTTP interface without needing to implement a server itself.
I was in the process of adding WebSocket support when I came across this plugin.
The changes I made to this plugin are quite minor but IMHO can be quite helpful for apache plugin writers.
I added a hook which gets called if WebSocketHandler is set to "internal" and there is no dso with this name.
Other plugins can hook into this and check if they are expected to handle it using the provided name.
If so they set the plugin pointer and from there everything is the same as normal.

@jchampio
Copy link
Owner

jchampio commented Jul 5, 2020

@Thalhammer Neat idea. I'm so sorry it's been three years since you opened this PR -- before I start taking a closer look, is this something you'd still find useful?

@jchampio jchampio added this to the 0.2 - Pre-release ABI Bump milestone Jul 5, 2020
@jchampio
Copy link
Owner

jchampio commented Jul 5, 2020

(milestone tentative; waiting on author)

@Thalhammer
Copy link
Author

Ofc I think its still usefull. In fact I use it everyday in production.

@jchampio
Copy link
Owner

jchampio commented Jul 5, 2020

Great! I want to think about this use case a bit more, and see if I can make your client code even easier with a more invasive change. Definitely a 0.2.x sort of thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants