Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the 'X-RateLimit-Reset' header #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davebrace
Copy link

Set the 'X-RateLimit-Reset' header to the number of seconds until the current throttle expires.

This implements what was proposed here: #2.

The 'X-RateLimit-Reset' header will be set to the number of seconds
until the current throttle expires.
@davebrace davebrace force-pushed the add-ratelimit-reset-header branch from 88de315 to 954bd04 Compare March 23, 2016 19:55
@pabuisson
Copy link

Any news about this PR @davebrace? I'm looking for this kind of feature as well.

@davebrace
Copy link
Author

@pabuisson No news - waiting for feedback from the project maintainer @jbyck.

We're using a custom fork of this project in production that includes this feature.

@pabuisson
Copy link

pabuisson commented Nov 17, 2016

OK I'm following this PR closely then... and in case it does not merge soon, I'll do the same as you and use a fork of the project. But maybe we'll get some update from @jbyck !

@jbyck
Copy link
Owner

jbyck commented Nov 18, 2016

@pabuisson @davebrace sorry for the lack of communication here. I haven't been monitoring this project very well.

This looks reasonable to me, but the tests are failing in Travis. I'll be happy to merge and make a new release once it goes green.

I actually don't use this myself anymore in any current projects - if either of you are using it, and are interested, I'd be happy to pass on ownership for someone to maintain more actively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants