[ci] Run checks before tests (elastic#198452)

Should be the last group to move before tests for now. The intent has been to move steps that fit in the build window to run before tests start. Catching errors before parallel steps should help reduce the number of test runs with known issues.
jbudz · Nov 4, 2024 · 25fb36c · 25fb36c
1 parent 842d309
commit 25fb36c
Show file tree

Hide file tree

Showing 27 changed files with 112 additions and 52 deletions.
diff --git a/.buildkite/pipelines/on_merge.yml b/.buildkite/pipelines/on_merge.yml
@@ -45,6 +45,20 @@ steps:
         - exit_status: '-1'
           limit: 3
 
+  - command: .buildkite/scripts/steps/checks.sh
+    label: 'Checks'
+    agents:
+      image: family/kibana-ubuntu-2004
+      imageProject: elastic-images-prod
+      provider: gcp
+      machineType: n2-standard-2
+      preemptible: true
+    timeout_in_minutes: 60
+    retry:
+      automatic:
+        - exit_status: '-1'
+          limit: 3
+
   - command: .buildkite/scripts/steps/lint.sh
     label: 'Linting'
     agents:
@@ -89,6 +103,20 @@ steps:
         - exit_status: '-1'
           limit: 3
 
+  - command: .buildkite/scripts/steps/checks/capture_oas_snapshot.sh
+    label: 'Check OAS Snapshot'
+    agents:
+      image: family/kibana-ubuntu-2004
+      imageProject: elastic-images-prod
+      provider: gcp
+      machineType: n2-standard-4
+      preemptible: true
+    timeout_in_minutes: 60
+    retry:
+      automatic:
+        - exit_status: '-1'
+          limit: 3
+
   - wait
 
   - command: .buildkite/scripts/steps/on_merge_api_docs.sh
@@ -317,34 +345,6 @@ steps:
       provider: gcp
       machineType: n2-standard-2
 
-  - command: .buildkite/scripts/steps/checks.sh
-    label: 'Checks'
-    agents:
-      image: family/kibana-ubuntu-2004
-      imageProject: elastic-images-prod
-      provider: gcp
-      machineType: n2-standard-2
-      preemptible: true
-    timeout_in_minutes: 60
-    retry:
-      automatic:
-        - exit_status: '-1'
-          limit: 3
-
-  - command: .buildkite/scripts/steps/checks/capture_oas_snapshot.sh
-    label: 'Check OAS Snapshot'
-    agents:
-      image: family/kibana-ubuntu-2004
-      imageProject: elastic-images-prod
-      provider: gcp
-      machineType: n2-standard-2
-      preemptible: true
-    timeout_in_minutes: 60
-    retry:
-      automatic:
-        - exit_status: '-1'
-          limit: 3
-
   - command: .buildkite/scripts/steps/storybooks/build_and_upload.sh
     label: 'Build Storybooks'
     agents:

diff --git a/.buildkite/pipelines/pull_request/apm_cypress.yml b/.buildkite/pipelines/pull_request/apm_cypress.yml
@@ -7,9 +7,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 120
     parallelism: 1 # TODO: Set parallelism when apm_cypress handles it
     retry:

diff --git a/.buildkite/pipelines/pull_request/base.yml b/.buildkite/pipelines/pull_request/base.yml
@@ -32,6 +32,18 @@ steps:
         - exit_status: '-1'
           limit: 3
 
+  - command: .buildkite/scripts/steps/checks.sh
+    label: 'Checks'
+    key: checks
+    agents:
+      machineType: n2-standard-2
+      preemptible: true
+    timeout_in_minutes: 60
+    retry:
+      automatic:
+        - exit_status: '-1'
+          limit: 3
+
   - command: .buildkite/scripts/steps/lint.sh
     label: 'Linting'
     agents:
@@ -56,6 +68,18 @@ steps:
         - exit_status: '-1'
           limit: 3
 
+  - command: .buildkite/scripts/steps/checks/capture_oas_snapshot.sh
+    label: 'Check OAS Snapshot'
+    agents:
+      machineType: n2-standard-4
+      preemptible: true
+    key: check_oas_snapshot
+    timeout_in_minutes: 60
+    retry:
+      automatic:
+        - exit_status: '-1'
+          limit: 3
+
   - command: .buildkite/scripts/steps/check_types.sh
     label: 'Check Types'
     agents:
@@ -99,29 +123,6 @@ steps:
         - exit_status: '*'
           limit: 1
 
-  - command: .buildkite/scripts/steps/checks.sh
-    label: 'Checks'
-    key: checks
-    agents:
-      machineType: n2-standard-2
-      preemptible: true
-    timeout_in_minutes: 60
-    retry:
-      automatic:
-        - exit_status: '-1'
-          limit: 3
-
-  - command: .buildkite/scripts/steps/checks/capture_oas_snapshot.sh
-    label: 'Check OAS Snapshot'
-    agents:
-      machineType: n2-standard-2
-      preemptible: true
-    timeout_in_minutes: 60
-    retry:
-      automatic:
-        - exit_status: '-1'
-          limit: 3
-
   - command: .buildkite/scripts/steps/api_docs/build_api_docs.sh
     label: 'Build API Docs'
     agents:

diff --git a/.buildkite/pipelines/pull_request/deploy_cloud.yml b/.buildkite/pipelines/pull_request/deploy_cloud.yml
@@ -7,9 +7,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 30
     soft_fail: true
     retry:

diff --git a/.buildkite/pipelines/pull_request/exploratory_view_plugin.yml b/.buildkite/pipelines/pull_request/exploratory_view_plugin.yml
@@ -7,9 +7,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 60
     artifact_paths:
       - 'x-pack/plugins/observability_solution/exploratory_view/e2e/.journeys/**/*'

diff --git a/.buildkite/pipelines/pull_request/fips.yml b/.buildkite/pipelines/pull_request/fips.yml
@@ -7,9 +7,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 60
     soft_fail: true
     retry:

diff --git a/.buildkite/pipelines/pull_request/fleet_cypress.yml b/.buildkite/pipelines/pull_request/fleet_cypress.yml
@@ -7,9 +7,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 50
     parallelism: 6
     retry:

diff --git a/.buildkite/pipelines/pull_request/kbn_handlebars.yml b/.buildkite/pipelines/pull_request/kbn_handlebars.yml
@@ -7,9 +7,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 5
     retry:
       automatic:

diff --git a/.buildkite/pipelines/pull_request/observability_onboarding_cypress.yml b/.buildkite/pipelines/pull_request/observability_onboarding_cypress.yml
@@ -7,9 +7,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 120
     retry:
       automatic:

diff --git a/.buildkite/pipelines/pull_request/profiling_cypress.yml b/.buildkite/pipelines/pull_request/profiling_cypress.yml
@@ -7,9 +7,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 120
     parallelism: 2
     retry:

diff --git a/.buildkite/pipelines/pull_request/response_ops.yml b/.buildkite/pipelines/pull_request/response_ops.yml
@@ -7,9 +7,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 120
     parallelism: 9
     retry:

diff --git a/.buildkite/pipelines/pull_request/response_ops_cases.yml b/.buildkite/pipelines/pull_request/response_ops_cases.yml
@@ -7,9 +7,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 120
     retry:
       automatic:

diff --git a/.buildkite/pipelines/pull_request/security_solution/ai_assistant.yml b/.buildkite/pipelines/pull_request/security_solution/ai_assistant.yml
@@ -7,9 +7,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 60
     parallelism: 1
     retry:

diff --git a/.buildkite/pipelines/pull_request/security_solution/cloud_security_posture.yml b/.buildkite/pipelines/pull_request/security_solution/cloud_security_posture.yml
@@ -7,9 +7,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 60
     parallelism: 1
     retry:
@@ -25,9 +27,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 60
     parallelism: 1
     retry:

diff --git a/.buildkite/pipelines/pull_request/security_solution/cypress_burn.yml b/.buildkite/pipelines/pull_request/security_solution/cypress_burn.yml
@@ -9,9 +9,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 60
     soft_fail: true
     parallelism: 1
@@ -26,9 +28,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 60
     parallelism: 1
     retry:
@@ -43,9 +47,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 50
     soft_fail: true
     retry:

diff --git a/.buildkite/pipelines/pull_request/security_solution/defend_workflows.yml b/.buildkite/pipelines/pull_request/security_solution/defend_workflows.yml
@@ -9,9 +9,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 60
     parallelism: 20
     retry:

diff --git a/.buildkite/pipelines/pull_request/security_solution/detection_engine.yml b/.buildkite/pipelines/pull_request/security_solution/detection_engine.yml
@@ -7,9 +7,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 60
     parallelism: 5
     retry:
@@ -25,9 +27,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 60
     parallelism: 2
     retry:

diff --git a/.buildkite/pipelines/pull_request/security_solution/entity_analytics.yml b/.buildkite/pipelines/pull_request/security_solution/entity_analytics.yml
@@ -7,9 +7,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 60
     parallelism: 2
     retry:

diff --git a/.buildkite/pipelines/pull_request/security_solution/explore.yml b/.buildkite/pipelines/pull_request/security_solution/explore.yml
@@ -7,9 +7,11 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - checks
       - linting
       - linting_with_types
       - check_types
+      - check_oas_snapshot
     timeout_in_minutes: 60
     parallelism: 2
     retry: