FUSETOOLS-3655 - Provide property for additional exports for JDK 17 #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it avoids this kind of error java.lang.IllegalAccessException: class org.jboss.tools.common.jdt.debug.tools.internal.Tools cannot access class sun.jvmstat.monitor.MonitoredHost (in module jdk.internal.jvmstat) because module jdk.internal.jvmstat does not export sun.jvmstat.monitor to unnamed module it is provided in p2.inf but need to add it in test explicitely too. See https://github.com/jbosstools/jbosstools-base/blob/main/common/plugins/org.jboss.tools.common.jdt.debug/META-INF/p2.inf Signed-off-by: Aurélien Pupier <[email protected]>
apupier
added a commit
to apupier/jbosstools-fuse
that referenced
this pull request
Jul 26, 2022
it avoids this kind of error java.lang.IllegalAccessException: class org.jboss.tools.common.jdt.debug.tools.internal.Tools cannot access class sun.jvmstat.monitor.MonitoredHost (in module jdk.internal.jvmstat) because module jdk.internal.jvmstat does not export sun.jvmstat.monitor to unnamed module it is provided in p2.inf but need to add it in test explicitely too. See https://github.com/jbosstools/jbosstools-base/blob/main/common/plugins/org.jboss.tools.common.jdt.debug/META-INF/p2.inf This will need to be updated to reuse property coming from Jboss Tools parent when available jbosstools/jbosstools-build#332 Signed-off-by: Aurélien Pupier <[email protected]>
apupier
added a commit
to apupier/jbosstools-fuse
that referenced
this pull request
Jul 27, 2022
it avoids this kind of error java.lang.IllegalAccessException: class org.jboss.tools.common.jdt.debug.tools.internal.Tools cannot access class sun.jvmstat.monitor.MonitoredHost (in module jdk.internal.jvmstat) because module jdk.internal.jvmstat does not export sun.jvmstat.monitor to unnamed module it is provided in p2.inf but need to add it in test explicitely too. See https://github.com/jbosstools/jbosstools-base/blob/main/common/plugins/org.jboss.tools.common.jdt.debug/META-INF/p2.inf This will need to be updated to reuse property coming from Jboss Tools parent when available jbosstools/jbosstools-build#332 Signed-off-by: Aurélien Pupier <[email protected]>
apupier
added a commit
to apupier/jbosstools-fuse
that referenced
this pull request
Jul 27, 2022
it avoids this kind of error java.lang.IllegalAccessException: class org.jboss.tools.common.jdt.debug.tools.internal.Tools cannot access class sun.jvmstat.monitor.MonitoredHost (in module jdk.internal.jvmstat) because module jdk.internal.jvmstat does not export sun.jvmstat.monitor to unnamed module it is provided in p2.inf but need to add it in test explicitely too. See https://github.com/jbosstools/jbosstools-base/blob/main/common/plugins/org.jboss.tools.common.jdt.debug/META-INF/p2.inf This will need to be updated to reuse property coming from Jboss Tools parent when available jbosstools/jbosstools-build#332 Signed-off-by: Aurélien Pupier <[email protected]>
apupier
added a commit
to apupier/jbosstools-fuse
that referenced
this pull request
Jul 27, 2022
it avoids this kind of error java.lang.IllegalAccessException: class org.jboss.tools.common.jdt.debug.tools.internal.Tools cannot access class sun.jvmstat.monitor.MonitoredHost (in module jdk.internal.jvmstat) because module jdk.internal.jvmstat does not export sun.jvmstat.monitor to unnamed module it is provided in p2.inf but need to add it in test explicitely too. See https://github.com/jbosstools/jbosstools-base/blob/main/common/plugins/org.jboss.tools.common.jdt.debug/META-INF/p2.inf This will need to be updated to reuse property coming from Jboss Tools parent when available jbosstools/jbosstools-build#332 Signed-off-by: Aurélien Pupier <[email protected]>
apupier
added a commit
to apupier/jbosstools-fuse
that referenced
this pull request
Jul 27, 2022
it avoids this kind of error java.lang.IllegalAccessException: class org.jboss.tools.common.jdt.debug.tools.internal.Tools cannot access class sun.jvmstat.monitor.MonitoredHost (in module jdk.internal.jvmstat) because module jdk.internal.jvmstat does not export sun.jvmstat.monitor to unnamed module it is provided in p2.inf but need to add it in test explicitely too. See https://github.com/jbosstools/jbosstools-base/blob/main/common/plugins/org.jboss.tools.common.jdt.debug/META-INF/p2.inf This will need to be updated to reuse property coming from Jboss Tools parent when available jbosstools/jbosstools-build#332 Signed-off-by: Aurélien Pupier <[email protected]>
apupier
added a commit
to jbosstools/jbosstools-fuse
that referenced
this pull request
Jul 27, 2022
it avoids this kind of error java.lang.IllegalAccessException: class org.jboss.tools.common.jdt.debug.tools.internal.Tools cannot access class sun.jvmstat.monitor.MonitoredHost (in module jdk.internal.jvmstat) because module jdk.internal.jvmstat does not export sun.jvmstat.monitor to unnamed module it is provided in p2.inf but need to add it in test explicitely too. See https://github.com/jbosstools/jbosstools-base/blob/main/common/plugins/org.jboss.tools.common.jdt.debug/META-INF/p2.inf This will need to be updated to reuse property coming from Jboss Tools parent when available jbosstools/jbosstools-build#332 Signed-off-by: Aurélien Pupier <[email protected]>
jeffmaury
requested changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it avoids this kind of error java.lang.IllegalAccessException: class
org.jboss.tools.common.jdt.debug.tools.internal.Tools cannot access
class sun.jvmstat.monitor.MonitoredHost (in module jdk.internal.jvmstat)
because module jdk.internal.jvmstat does not export sun.jvmstat.monitor
to unnamed module
it is provided in p2.inf but need to add it in test explicitely too. See
https://github.com/jbosstools/jbosstools-base/blob/main/common/plugins/org.jboss.tools.common.jdt.debug/META-INF/p2.inf
Signed-off-by: Aurélien Pupier [email protected]