[CLOUD-1867] update datavirt-app-config secret to use new src location #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcernich
reviewed
Sep 6, 2017
| @@ -30,7 +30,6 @@ Feature: Openshift JDV s2i tests | |||
| | EXCEL_CONNECTION_JNDI | java:/excel-file | | |||
| | EXCEL_PROPERTY_ParentDirectory | /home/jboss/source/data/teiidfiles/excelFiles/ | | |||
| | EXCEL_PROPERTY_AllowParentPaths | true | | |||
| | APP_DATADIR | data | | |||
There was a problem hiding this comment.
Should we add a test that checks for a non-default value for APP_DATADIR?
rcernich
previously approved these changes
Sep 12, 2017
osnipso
changed the title
7 tasks
Change existing test to rely on new default value for APP_DATADIR (== data) Add new test for custom APP_DATADIR Signed-off-by: Osni Oliveira <[email protected]>
osnipso
changed the title
rcernich
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: CLOUD-1867
Changes default value for APP_DATADIR (== data). Also, change tests to rely on new default value for APP_DATADIR.
Update datavirt-app-config secret to use new src location (/opt/eap/standalone/data/).
Add a new CTF test for custom APP_DATADIR value.
This PR works in conjunction with #387 in application-templates.
This PR replaces #305 in application-templates.
Please make sure your PR meets following requirements:
[CLOUD-XYA] SubjectCONTRIBUTING.md)Signed-off-by: Your Name <[email protected]>- usegit commit -s