Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jira SO-19: Remove non-groupified APIs in openshift/library templates #501

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

fbm3307
Copy link

@fbm3307 fbm3307 commented May 13, 2022

This PR only handles the imagestreams/Templates which are bundled in OpenShift. If any of the other imagestreams or templates are meant to still be used, they should also be similarly updated. A complete API list is available at https://docs.openshift.com/container-platform/4.10/rest_api/index.html

Signed-off-by: Feny Mehta [email protected]

@fbm3307
Copy link
Author

fbm3307 commented May 13, 2022

/cc @yselkowitz

@yselkowitz
Copy link

LGTM, but my question is how many of these are actually still supported. AMQ 6.3 still is, but that means 6.2 should not be. Data Grid 7.1 has been supplanted by 7.3 (which is now in maintenance support with 8.y being operator-based). EAP 6.4 is about to go into ELS 2 meaning there will be no further updates, and 7.0/7.1 have been supplanted by 7.4. Therefore, some or all of these (except for amq63) could simply be removed from OCP4 in openshift/library. Hopefully the maintainers here can provide some guidance.

@yselkowitz
Copy link

So there is agreement to remove the old versions here, but we still need amq63 fixed, which will also require a new tag here.

@yselkowitz
Copy link

@fbm3307 could you modify this PR to only fix the amq63 files? The others are being dropped, so there is no reason to modify them.

@fbm3307
Copy link
Author

fbm3307 commented Jun 9, 2022

@yselkowitz changed it

@yselkowitz
Copy link

@fbm3307 just discovered that AMQ 6.3 is not supported on OCP 4: https://access.redhat.com/articles/310613

Therefore, I think we can just close this and merge openshift/library#323 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants