Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate OpenTracing tests from Thorntail test suite #199

Merged
merged 1 commit into from
May 14, 2020
Merged

Migrate OpenTracing tests from Thorntail test suite #199

merged 1 commit into from
May 14, 2020

Conversation

zhantemirov
Copy link

Based on #10 issue.

Please make sure your PR meets the following requirements:

  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is formatted, imports ordered, code compiles and tests are passing
  • Link to the passing job is provided
  • Code is self-descriptive and/or documented
  • Description of the tests scenarios is included (see Update PR template to include TPG stuff #46)

@zhantemirov zhantemirov requested a review from a team January 24, 2020 12:57
@zhantemirov zhantemirov mentioned this pull request Jan 30, 2020
Closed
@zhantemirov
Copy link
Author

@mnovak1 force-pushed with last changes.

@mnovak1
Copy link
Member

mnovak1 commented Feb 19, 2020

Looks like there is formatting change as travis failed. Could you run TS locally and commit the formatting changes, please?

@zhantemirov zhantemirov force-pushed the migrate-open-tracing branch 2 times, most recently from c715a87 to 6795636 Compare February 21, 2020 11:33
@mnovak1
Copy link
Member

mnovak1 commented Feb 25, 2020

@zhantemirov are the test passing now?

@honza-kasik
Copy link
Member

@zhantemirov Hi! Is this now ready? If it is, can you please provide link to passing job and resolve conflicts so this can be merged?

@zhantemirov
Copy link
Author

@honza-kasik @mnovak1 passing tests job link - https://eap-qe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/eap-7.x-microprofile-testsuite/217/

Conflicts are resolved, thanks

@mnovak1
Copy link
Member

mnovak1 commented May 14, 2020

LGTM

@zhantemirov could you just confirm that tests are passing?

@mnovak1
Copy link
Member

mnovak1 commented May 14, 2020

The pipeline run with passing tests has rolled out thus I was asking but I trust that everything is ok. Merging.

@mnovak1 mnovak1 merged commit 20cf991 into jboss-eap-qe:master May 14, 2020
@zhantemirov
Copy link
Author

@mnovak1 sorry for the late response, but yes - the tests are passing.

@zhantemirov zhantemirov deleted the migrate-open-tracing branch May 28, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnovak1 mnovak1 mnovak1 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhantemirov @mnovak1 @honza-kasik