fix: resolve the wrong actual dragging item which drag from outside #760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation:
When I use the feature of dragging item from outside, I find the dragging item can't place in some specific position.
After researching, I found that the
grid-item
I got by the below codes is another existinggrid-item
.let index = this.layout.findIndex(item => item.i === 'drop');
let el = this.$refs.gridlayout.$children[index];
And it leads to the wrong result of
calcXY()
which based onw
andh
of the unexpectedgrid-item
.Root case:
The reason is mismatching between
layout
sort and$refs.gridlayout.$children
sort. So we may get unexpectedgird-item
by using index oflayout
.Refer: https://v2.vuejs.org/v2/api/index.html#vm-children
Solution:
Instead of
layout
, getgrid-item
by$refs.gridlayout.$children
directly. Like below:let el = this.$refs.gridlayout.$children.find(el => el.i === 'drop' && !el.$el.classList.contains('vue-grid-placeholder'))
Ps:
i
ofvue-grid-placeholder
also is 'drop'